ocp: Fix timestamp displayed by fw-activate-history command #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code is displaying all 8 bytes of the timestamp field for the timestamp. The timestamp value is only in the first 6 bytes. The 7th byte contains the origin and synch fields and the 8th byte is reserved. Signed-off-by: jeff-lien-wdc <[email protected]>
|
Thanks! |
|
@igaw I noticed my commits for this PR and PR #2229 show up as "Unverified" and was wondering why? I do have a gpg key setup so when I commit changes to my forked repo, they show up as "Verified". Do I need to setup a gpg key or do something else in the main repo to make my commits verified? Is this a problem? |
|
It looks like when I click the 'rebase & merge' button github is not able to track the signature: |
|
Thanks Dan. I've subscribed to that discussion. Hopefully it will be fixed soon. |
|
We could obviously just go back to the merge PR workflow but I really don't like it. It's just a lot of noise in the git history and this is a simple project and not the linux kernel where this additional information makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is displaying all 8 bytes of the timestamp field for the timestamp. The timestamp value is only in the first 6 bytes. The 7th byte contains the origin and synch fields and the 8th byte is reserved.